Archives de la liste dev@paheko.cloud
Bug: pb de validation, mauvais champs validé sur le tarif lors de l'import d'une activité utilisateur
mail at matthieubessat.fr via dev
28/12/2023 12:21:08
--ac386ac0cba8b1b5d5635a171470dbf181e0a5f7900ffb10c395cd4b2901
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Bonjour,
J'ai un probl=C3=A8me sur le endpoint `POST /api/services/subscriptions/imp=
ort`,
En effet, paheko me dit que "Le tarif machin n'existe pas pour cette activi=
t=C3=A9", alors que le nom du tarif fourni est correct.
Donc je regarde dans le code, je remarque cette condition ici :
`src/include/lib/Paheko/Services/Services_User.php` ligne 147
```
if (strcasecmp($fee->label, $row->fee) =3D=3D=3D 0 && $fee->id =3D=3D=3D
$i=
d_service) {
```
Je pense que l'intention de `$fee->id =3D=3D=3D $id_service` c'est
`$fee->i=
d_service =3D=3D=3D $id_service`
Je propose ce patch pour corriger le bug.
```
Index: src/include/lib/Paheko/Services/Services_User.php
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- src/include/lib/Paheko/Services/Services_User.php
+++ src/include/lib/Paheko/Services/Services_User.php
@@ -142,11 +142,11 @@
$id_fee =3D null;
if (!empty($row->fee)) {
foreach ($fees as $fee) {
- if (strcasecmp($fee->label, $row->fee) =3D=3D=3D 0 && $fee->id
=3D=
=3D=3D $id_service) {
+ if (strcasecmp($fee->label, $row->fee) =3D=3D=3D 0 &&
$fee->id_servi=
ce =3D=3D=3D $id_service) {
$id_fee =3D $fee->id;
break;
}
}
```
Librement,
--=20
Matthieu Bessat <mail@matthieubessat.fr>
Website: https://matthieubessat.fr
GPG Fingerprint: F3E0395DC15CD92D
--ac386ac0cba8b1b5d5635a171470dbf181e0a5f7900ffb10c395cd4b2901
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iHUEABYIAB0WIQQRYe1okINIY4xZaHEIxGwvFBSsgQUCZY1aFAAKCRAIxGwvFBSs
gcpOAQCSEY6p2bPFnUufWBCmE7u3XT9K2SRUgGzXXbXHpMQP5QD/fY8LSoUsXNs2
eYjSxr/pSAqI0Ap5NAZspvRlgmoElA8=
=iWMZ
-----END PGP SIGNATURE-----
--ac386ac0cba8b1b5d5635a171470dbf181e0a5f7900ffb10c395cd4b2901--